72 lines
1.8 KiB
JavaScript
72 lines
1.8 KiB
JavaScript
|
/**
|
||
|
|
* Rule: no-callback-in-promise
|
||
|
|
* Avoid calling back inside of a promise
|
||
|
|
*/
|
||
|
|
|
||
|
|
'use strict'
|
||
|
|
|
||
|
|
const getDocsUrl = require('./lib/get-docs-url')
|
||
|
|
const hasPromiseCallback = require('./lib/has-promise-callback')
|
||
|
|
const isInsidePromise = require('./lib/is-inside-promise')
|
||
|
|
const isCallback = require('./lib/is-callback')
|
||
|
|
|
||
|
|
module.exports = {
|
||
|
|
meta: {
|
||
|
|
type: 'suggestion',
|
||
|
|
docs: {
|
||
|
|
url: getDocsUrl('no-callback-in-promise'),
|
||
|
|
},
|
||
|
|
messages: {
|
||
|
|
callback: 'Avoid calling back inside of a promise.',
|
||
|
|
},
|
||
|
|
schema: [
|
||
|
|
{
|
||
|
|
type: 'object',
|
||
|
|
properties: {
|
||
|
|
exceptions: {
|
||
|
|
type: 'array',
|
||
|
|
items: {
|
||
|
|
type: 'string',
|
||
|
|
},
|
||
|
|
},
|
||
|
|
},
|
||
|
|
additionalProperties: false,
|
||
|
|
},
|
||
|
|
],
|
||
|
|
},
|
||
|
|
create(context) {
|
||
|
|
return {
|
||
|
|
CallExpression(node) {
|
||
|
|
const options = context.options[0] || {}
|
||
|
|
const exceptions = options.exceptions || []
|
||
|
|
if (!isCallback(node, exceptions)) {
|
||
|
|
// in general we send you packing if you're not a callback
|
||
|
|
// but we also need to watch out for whatever.then(cb)
|
||
|
|
if (hasPromiseCallback(node)) {
|
||
|
|
const name =
|
||
|
|
node.arguments && node.arguments[0] && node.arguments[0].name
|
||
|
|
if (
|
||
|
|
name === 'callback' ||
|
||
|
|
name === 'cb' ||
|
||
|
|
name === 'next' ||
|
||
|
|
name === 'done'
|
||
|
|
) {
|
||
|
|
context.report({
|
||
|
|
node: node.arguments[0],
|
||
|
|
messageId: 'callback',
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|
||
|
|
return
|
||
|
|
}
|
||
|
|
if (context.getAncestors().some(isInsidePromise)) {
|
||
|
|
context.report({
|
||
|
|
node,
|
||
|
|
messageId: 'callback',
|
||
|
|
})
|
||
|
|
}
|
||
|
|
},
|
||
|
|
}
|
||
|
|
},
|
||
|
|
}
|