Compare commits

...

2 commits

Author SHA1 Message Date
55b94d0021
bump version to 1.11.1
All checks were successful
Upload release / build (push) Successful in 1m54s
2024-10-01 16:55:12 +02:00
4f34191d2f
don't crash when trying to compress an enormous file 2024-10-01 16:55:06 +02:00
3 changed files with 61 additions and 41 deletions

View file

@ -1,6 +1,6 @@
{ {
"name": "dsr", "name": "dsr",
"version": "1.11.0", "version": "1.11.1",
"description": "Discord Video Sharing", "description": "Discord Video Sharing",
"main": "./dist/main.js", "main": "./dist/main.js",
"scripts": { "scripts": {

View file

@ -144,7 +144,9 @@ app.whenReady().then(() => {
}; };
}; };
/** Reduce size of a file */ /** Reduce size of a file
* Returns an empty string in case of failing
*/
const reduceSize = async ( const reduceSize = async (
file: string, file: string,
bitrate: number, bitrate: number,
@ -153,46 +155,48 @@ app.whenReady().then(() => {
const audioBitrate = Math.ceil( const audioBitrate = Math.ceil(
audioTracks.reduce((sum, current) => current + sum, 0) audioTracks.reduce((sum, current) => current + sum, 0)
); );
let videoBitrate = bitrate - audioBitrate; const videoBitrate = bitrate - audioBitrate;
let finalFile;
const finalFile = getNewFilename(file, "Compressed - "); if (videoBitrate > 0) {
finalFile = getNewFilename(file, "Compressed - ");
// Trash the output, depends on the platform // Trash the output, depends on the platform
const nul = process.platform === "win32" ? "NUL" : "/dev/null"; const nul = process.platform === "win32" ? "NUL" : "/dev/null";
// Mapping of tracks for FFMPEG, adding 1 for the video stream // Mapping of tracks for FFMPEG, adding 1 for the video stream
const mappingTracks = Array(audioTracks.length + 1) const mappingTracks = Array(audioTracks.length + 1)
.fill("-map 0:") .fill("-map 0:")
.map((str, index) => { .map((str, index) => {
return str + index; return str + index;
}) })
.join(" "); .join(" ");
let codec = "libx264"; let codec = "libx264";
let hwAcc = ""; let hwAcc = "";
const argv = process.argv; const argv = process.argv;
if (argv.includes("/nvenc_h264")) { if (argv.includes("/nvenc_h264")) {
// Use NVenc H.264 // Use NVenc H.264
codec = "h264_nvenc"; codec = "h264_nvenc";
hwAcc = "-hwaccel cuda"; hwAcc = "-hwaccel cuda";
} }
if (argv.includes("/nvenc_h265")) { if (argv.includes("/nvenc_h265")) {
// Use NVenc H.265 // Use NVenc H.265
codec = "hevc_nvenc"; codec = "hevc_nvenc";
hwAcc = "-hwaccel cuda"; hwAcc = "-hwaccel cuda";
} }
if (argv.includes("/h265")) { if (argv.includes("/h265")) {
// Use H.265 encoder // Use H.265 encoder
codec = "libx265"; codec = "libx265";
} }
// Compress the video // Compress the video
// Add metadata to audio's track // Add metadata to audio's track
await execute( await execute(
`"${ffmpegPath}" -y ${hwAcc} \ `"${ffmpegPath}" -y ${hwAcc} \
-i "${file}" \ -i "${file}" \
-c:v ${codec} -b:v ${videoBitrate}k -pass 1 -an -f mp4 \ -c:v ${codec} -b:v ${videoBitrate}k -pass 1 -an -f mp4 \
${nul} \ ${nul} \
@ -205,14 +209,17 @@ app.whenReady().then(() => {
${audioTracks.length === metadataAudioSize ? metadataAudio : ""} \ ${audioTracks.length === metadataAudioSize ? metadataAudio : ""} \
${shareOpt} \ ${shareOpt} \
"${finalFile}"` "${finalFile}"`
).catch((e) => registerError(win, e)); ).catch((e) => registerError(win, e));
// Delete the 2 pass temporary files
deleteTwoPassFiles(process.cwd());
} else {
finalFile = "";
}
// Delete the old video file // Delete the old video file
deleteFile(file); deleteFile(file);
// Delete the 2 pass temporary files
deleteTwoPassFiles(process.cwd());
return finalFile; return finalFile;
}; };

View file

@ -103,6 +103,7 @@ const main = async () => {
updateMessage("Récupération des fichiers..."); updateMessage("Récupération des fichiers...");
const files = await getFiles(); const files = await getFiles();
let processedFiles = ""; let processedFiles = "";
let numberOfUncompressableFiles = 0;
// Iterate over all the retrieved files // Iterate over all the retrieved files
for (const [idx, file] of files.entries()) { for (const [idx, file] of files.entries()) {
@ -148,14 +149,26 @@ const main = async () => {
} }
// Append title to the list of processed files // Append title to the list of processed files
processedFiles += `\n- ${finalTitle}`; if (finalTitle.length > 0) {
updateMessage(`Fichier ${counter} traités.`); processedFiles += `\n- ${finalTitle}`;
updateMessage(`Fichier ${counter} traités.`);
} else {
processedFiles += `\n- ${file} [incompressable]`;
updateMessage(`Fichier ${counter} trop large pour être compressé.`);
numberOfUncompressableFiles++;
}
}
let errorMessage = "";
if (numberOfUncompressableFiles > 0) {
errorMessage += `\nNombre de fichier incompressable : ${numberOfUncompressableFiles}.`;
} }
// Send confirmation to the user that we're done // Send confirmation to the user that we're done
await internals.confirmation( await internals.confirmation(
`${files.length} fichiers traités : ${processedFiles}` `${files.length} fichiers traités : ${processedFiles}` + errorMessage
); );
await internals.exit(); await internals.exit();
}; };