fix: time related issues (#179)

- cleanup some code
- fix #100 (finally!)
- update some dependencie
   There is an issue with thoses one:
    @typescript-eslint/eslint-plugin": "~8.7.0"
    @typescript-eslint/parser": "~8.7.0"

Reviewed-on: #179
Co-authored-by: Mylloon <kennel.anri@tutanota.com>
Co-committed-by: Mylloon <kennel.anri@tutanota.com>

package.json

@@ -25,7 +25,6 @@
     "discord-player": "^6.7.1",
     "discord.js": "^14.16.2",
     "mediaplex": "^0.0.9",
-    "puppeteer": "^23.4.0",
     "sqlite3": "^5.1.7",
     "typescript": "^5.6.2",
     "uuid": "^10.0.0"

src/events/message/messageCreate.ts

@@ -98,21 +98,23 @@ export default async (message: Message, client: Client) => {
   const loc = getLocale(client, client.config.default_lang);
 
   // Remove duplicates then map the quoted posts
-  [...new Set(messages)].map((quoted_post) => {
+  [...new Set(messages)]
+    .filter((p) => p !== undefined)
+    .map((quoted_post) => {
       const embed = new EmbedBuilder().setColor("#2f3136").setAuthor({
         name: "Citation",
-      iconURL: quoted_post?.author.displayAvatarURL(),
+        iconURL: quoted_post.author.displayAvatarURL(),
       });
 
       // Handle attachments
-    if (quoted_post?.attachments.size !== 0) {
-      if (quoted_post?.attachments.size === 1 && isImage(quoted_post.attachments.first()!.name)) {
+      if (quoted_post.attachments.size !== 0) {
+        if (quoted_post.attachments.size === 1 && isImage(quoted_post.attachments.first()!.name)) {
           // Only contains one image
           embed.setImage(quoted_post.attachments.first()!.url);
         } else {
           // Contains more than one image and/or other files
           let files = "";
-        quoted_post?.attachments.forEach((file) => (files += `[${file.name}](${file.url}), `));
+          quoted_post.attachments.forEach((file) => (files += `[${file.name}](${file.url}), `));
           embed.addFields({
             // TODO: Don't pluralize when there is only one file.
             // TODO: Locales
@@ -125,22 +127,31 @@ export default async (message: Message, client: Client) => {
       }
 
       // Description as post content
-    if (quoted_post?.content) {
+      if (quoted_post.content) {
         // Only if content exists and length > 0
-      embed.setDescription(quoted_post?.content);
+        embed.setDescription(quoted_post.content);
       }
 
       // Footer
-    let footer = `Posté le ${showDate(loc, quoted_post!.createdAt)}`;
-    if (quoted_post?.editedAt) {
-      footer += ` et modifié le ${showDate(loc, quoted_post.editedAt)}`;
+      let footer = `Posté le ${showDate(
+        message.guild?.preferredLocale ?? client.config.default_lang,
+        loc,
+        quoted_post.createdAt,
+      )}`;
+      if (quoted_post.editedAt) {
+        footer += ` et modifié le ${showDate(
+          message.guild?.preferredLocale ?? client.config.default_lang,
+          loc,
+          quoted_post.editedAt,
+        )}`;
       }
 
       let author = "Auteur";
-    if (message.author === quoted_post?.author) {
+      if (message.author === quoted_post.author) {
         author += " & Citateur";
       } else {
         footer += `\nCité par ${userWithNickname(message.member!) ?? "?"} le ${showDate(
+          message.guild?.preferredLocale ?? client.config.default_lang,
           loc,
           message.createdAt,
         )}`;
@@ -155,12 +166,12 @@ export default async (message: Message, client: Client) => {
       embed.addFields(
         {
           name: author,
-        value: `${quoted_post?.author}`,
+          value: `${quoted_post.author}`,
           inline: true,
         },
         {
           name: "Message",
-        value: `${quoted_post?.channel} - [Lien Message](${quoted_post?.url})`,
+          value: `${quoted_post.channel} - [Lien Message](${quoted_post.url})`,
           inline: true,
         },
       );

src/utils/reminder.ts

@@ -414,6 +414,7 @@ export const embedListReminders = async (
         const expiration = `${loc.get("c_reminder8")} ${timeDeltaToString(remind.expiration_date)}`;
         embed.addFields({
           name: `#${remind.id} • ${loc.get("c_reminder9")} ${showDate(
+            local,
             loc,
             new Date(Number(remind.creation_date)),
           )}\n${expiration}`,

src/utils/time.ts

@@ -5,10 +5,8 @@
  * @param date Date
  * @returns String
  */
-export const showDate = (locale: Map<string, unknown>, date: Date) => {
-  const timezoned = new Date(date.getTime());
-  return `${timezoned.toDateString()} ${locale.get("u_time_at")} ${timezoned.toTimeString().split(" ")[0]}`;
-};
+export const showDate = (tz: string, locale: Map<string, unknown>, date: Date) =>
+  date.toLocaleString(tz).replace(" ", ` ${locale.get("u_time_at")} `);
 
 enum TimeSecond {
   Year = 31536000,